Hi Scott, On Wed, 2019-01-16 at 10:15 -0800, Scott Branden wrote: > On 2019-01-15 10:44 a.m., Florian Fainelli wrote: > > Add support for resetting blocks through the Linux reset controller > > subsystem when reset lines are provided through a SW_INIT-style reset > > controller on Broadcom STB SoCs. > > > > Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx> > > --- > > drivers/reset/Kconfig | 7 ++ > > drivers/reset/Makefile | 1 + > > drivers/reset/reset-brcmstb.c | 130 ++++++++++++++++++++++++++++++++++ > > 3 files changed, 138 insertions(+) > > create mode 100644 drivers/reset/reset-brcmstb.c > > > > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig > > index 2e01bd833ffd..1ca03c57e049 100644 > > --- a/drivers/reset/Kconfig > > +++ b/drivers/reset/Kconfig > > @@ -40,6 +40,13 @@ config RESET_BERLIN > > help > > This enables the reset controller driver for Marvell Berlin SoCs. > > > > +config RESET_BRCMSTB > > + bool "Broadcom STB reset controller" if COMPILE_TEST > > Could this even be: > > depends on ARCH_BRCMSTB || COMPILE_TEST I don't think this is necessary. Since the symbol is non-interactive if COMPILE_TEST is disabled, it just vanishes when both are disabled. > > + default ARCH_BRCMSTB And if it is actually needed, it defaults to the correct value. regards Philipp
