On Wed, Jan 16, 2019 at 6:26 AM Alexander Shiyan <shc_work@xxxxxxx> wrote: > > >Четверг, 3 января 2019, 23:59 +03:00 от Rob Herring <robh@xxxxxxxxxx>: > > > >On Sat, Dec 22, 2018 at 06:55:20PM +0300, Alexander Shiyan wrote: > >> Since the driver switched to using the syscon_regmap_lookup_by_phandle() > >> function, we need to specify the phandle for the driver. This patch > >> updates the driver binding documentation for these changes. > ... > >> diff --git a/Documentation/devicetree/bindings/input/clps711x-keypad.txt b/Documentation/devicetree/bindings/input/clps711x-keypad.txt > >> index 3eed881..aebedc3 100644 > >> --- a/Documentation/devicetree/bindings/input/clps711x-keypad.txt > >> +++ b/Documentation/devicetree/bindings/input/clps711x-keypad.txt > >> @@ -6,6 +6,7 @@ Required Properties: > >> - poll-interval: Poll interval time in milliseconds. > >> - linux,keymap: The definition can be found at > >> bindings/input/matrix-keymap.txt. > >> +- syscon: Phandle that points to the CPU syscon1 node. > > > >What does this provide? If the keypad registers are a sub-block of the > >syscon1, then you should make this node a child node. > > Syscon does not populate child devices. I don't have any context of what syscon1 looks like. Maybe it needs simple-mfd or a driver for the syscon. Rob
