On 21/01/19 12:44 PM, Thierry Reding wrote: > On Tue, Jan 15, 2019 at 11:03:52AM -0800, Sowjanya Komatineni wrote: >> This patch adds HW Command Queue for supported Tegra SDMMC >> controllers. >> >> Signed-off-by: Sowjanya Komatineni <skomatineni@xxxxxxxxxx> >> --- >> drivers/mmc/host/Kconfig | 1 + >> drivers/mmc/host/sdhci-tegra.c | 117 +++++++++++++++++++++++++++++++++++++++-- >> drivers/mmc/host/sdhci.c | 9 +++- >> drivers/mmc/host/sdhci.h | 2 + >> 4 files changed, 124 insertions(+), 5 deletions(-) > > Looks good to me. It might be worth splitting off the SDHCI core changes > into a separate patch, but that's for Adrian and Ulf to decide. From a Yes that would be better. Otherwise seems fine. > Tegra point of view: > > Acked-by: Thierry Reding <treding@xxxxxxxxxx> >