On Thu, Jan 17, 2019 at 02:30:13PM -0800, Nicolin Chen wrote: > On Mon, Jan 07, 2019 at 11:35:55AM -0800, Guenter Roeck wrote: > > > > + if (of_property_read_bool(np, "ti,single-shot")) > > > + ina->single_shot = true; > > > + > > ina->single_shot = of_property_read_bool(np, "ti,single-shot"); > > > > No need to resend right now; let's wait for feedback from Rob. > > Looks like Rob has acked. Is this resend version fine for review? > "Right now" was supposed to mean that you should wait for Rob's feedback before sending v3 with the feedback above applied. Did you send that version ? I don't see it in patchwork, nor in my inbox. Thanks, Guenter