Re: [PATCH 2/2] spi/fsl-lib: Get the SPI controller bus number from DTS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tue, Mar 18, 2014 at 07:40:28AM +0000, B48286@xxxxxxxxxxxxx wrote:

> > You are adding a property to specify a bus number.  There is no reason
> > why such a property should be specific to a single controller, every
> > controller in every system has a bus number assigned to it so if we have
> > a way to specify one controller via the device tree we should have a way
> > to specify it for all.

> The reason to specify a bus number to a single controller is to avoid 
> allocating one dynamically, so we know the bus number before booting up the
> kernel. If there are several controllers, you should add this property to all
> of them. But it is unnecessary to add this property, if you do not care about
> the bus number, and it will be allocated dynamically. 

Please re-read what I wrote above, you're completely missing the point.
The problem above is that you are adding this in driver specific code,
even if this is a good idea there's nothing specific to this device
about it so we shouldn't be doing it in a driver.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux