On 15-01-19, 15:03, Rob Herring wrote: > On Tue, Jan 08, 2019 at 09:59:22PM +0530, Vinod Koul wrote: > > Add support for Qualcomm ethqos found in some SoCs like QCS404. > > > > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx> > > --- > > .../devicetree/bindings/net/qcom,dwmac.txt | 129 ++++++++++++++++++ > > 1 file changed, 129 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/qcom,dwmac.txt > > > > diff --git a/Documentation/devicetree/bindings/net/qcom,dwmac.txt b/Documentation/devicetree/bindings/net/qcom,dwmac.txt > > new file mode 100644 > > index 000000000000..652d2213c3ac > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/qcom,dwmac.txt > > qcom,ethqos.txt? Sure, will update > > @@ -0,0 +1,129 @@ > > +Qualcomm Ethernet ETHQOS device > > + > > Perhaps some details like speeds and version of IP. There's lots of > variants. yeah it does Gigabit, so will update that as well. > > > +This device has following properties: > > + > > +Required properties: > > + > > +- compatible: Should be qcom,ethqos-qcs404" > > qcom,qcs404-ethqos Makes sense, thanks -- ~Vinod