Hi, On Wed, Jan 16, 2019 at 10:03 AM Jordan Crouse <jcrouse@xxxxxxxxxxxxxx> wrote: > > Add the nodes to describe the Adreno GPU and GMU devices for sdm845. > > Signed-off-by: Jordan Crouse <jcrouse@xxxxxxxxxxxxxx> > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > --- > This has the following dependencies: > > [v11,1/9] dt-bindings: opp: Introduce opp-level bindings > https://patchwork.kernel.org/patch/10755199/ > > And the following patches already in Rob's msm-next: > msm-next:d1c9cadea6f7 ("drm/msm/gpu: Remove hardcoded interrupt name") > msm-next:b08b92546807 ("drm/msm: drop interrupt-names") > msm-next:24937c540917 ("dt-bindings: drm/msm/a6xx: Document GMU and update GPU bindings") > > And finally drm/msm: Fix A6XX support for opp-level > https://patchwork.freedesktop.org/patch/276756/ > > Which is not merged because it too depends on Rajendra's stack. Newer version: https://lore.kernel.org/patchwork/patch/1032724/ ...that one should be able to land earlier since it's simpler. --- Don't forget that your patch also depends on: https://lkml.kernel.org/r/20181128185743.75328-2-dianders@xxxxxxxxxxxx ...because you won't compile unless gpucc is there. > arch/arm64/boot/dts/qcom/sdm845.dtsi | 121 +++++++++++++++++++++++++++++++++++ > 1 file changed, 121 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index f07c4ca..90766fc 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -1618,6 +1618,127 @@ > }; > }; > > + > + gpu@5000000 { Heads up to Andy that when this lands it should be re-sorted to be right before gpucc so that the unit addresses are sorted. :-) ...and while doing that we can make sure there's not an extra blank line. -Doug