On 18 March 2014 18:41, Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> wrote: > Initialize the 'regmap_rtc' on S2MPA01 to some sane value. Sane at least > for S5M87X chipsets, not S2MPS/S2MPA but it won't be used because > rtc-s5m driver does not support S2MPA01. > > This fixes following error: > drivers/mfd/sec-core.c:342:45: warning: 'regmap_rtc' may be used uninitialized in this function [-Wuninitialized] > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> >From the point of suppressing this warning and considering how it is done for S2MPS11, Acked-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx> However, shouldn't we be making this RTC handling conditional/optional depending upon whether the h/w or s/w supports/implements it? -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html