On Fri 04 Jan 2019 at 11:51, Rob Herring <robh+dt@xxxxxxxxxx> wrote: > On Fri, Dec 28, 2018 at 4:51 AM Loys Ollivier <lollivier@xxxxxxxxxxxx> wrote: >> >> Hello ! >> >> This patch series adds a new GNSS driver for the globaltop GNSS receivers. >> These receivers transmits NMEA output sequence as soon as they have booted. >> Power management can be done via the main supply and optional backup supply >> as defined in the device tree. >> >> The driver has been tested using a GlobalTop pa6h chipset on a Libretech-cc >> board using the expansion header. Changes made in the board device tree can >> be found below for reference and testing. >> >> Loys >> >> Loys Ollivier (4): >> dt-bindings: Add vendor prefix for "GlobalTop Technology, Inc." >> dt-bindings: gnss: add gtop binding >> gnss: add gtop receiver type support >> gnss: add driver for globaltop receivers >> >> Documentation/devicetree/bindings/gnss/gtop.txt | 33 +++++ >> .../devicetree/bindings/vendor-prefixes.txt | 1 + >> drivers/gnss/Kconfig | 13 ++ >> drivers/gnss/Makefile | 3 + >> drivers/gnss/core.c | 1 + >> drivers/gnss/gtop.c | 152 +++++++++++++++++++++ >> include/linux/gnss.h | 1 + >> 7 files changed, 204 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/gnss/gtop.txt >> create mode 100644 drivers/gnss/gtop.c >> >> --- >> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts >> index 90a56af967a7..3b3d4dcc47aa 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts >> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts >> @@ -17,6 +17,7 @@ >> >> aliases { >> serial0 = &uart_AO; >> + serial1 = &uart_A; > > You should not need this as the UART is not used as a tty. It could be > that the serial driver requires aliases, but that should be fixed. > There should be some examples of fixing this in other serial drivers. > Thanks Rob, Followed up on that [0]. [0]: https://lore.kernel.org/linux-amlogic/1547484866-3600-1-git-send-email-lollivier@xxxxxxxxxxxx/ >> ethernet0 = ðmac; >> }; > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-amlogic