On 1/11/19 7:01 AM, Rob Herring wrote: > On Wed, Jan 02, 2019 at 02:47:25PM +0530, Vinod Koul wrote: >> Some controllers require that phy delay should be disabled. So add > > If the MAC requires it, then the compatible string should imply this. If > it depends on the PHY, then okay. > >> optional properties rx-disable-delay and tx-disable-delay for it. >> >> Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/net/stmmac.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt >> index cb694062afff..ec18897e22c8 100644 >> --- a/Documentation/devicetree/bindings/net/stmmac.txt >> +++ b/Documentation/devicetree/bindings/net/stmmac.txt >> @@ -74,6 +74,8 @@ Optional properties: >> - snps,mb: mixed-burst >> - snps,rb: rebuild INCRx Burst >> - mdio: with compatible = "snps,dwmac-mdio", create and register mdio bus. >> +- rx-delay-disable: bool, when present disable the rx delay >> +- tx-delay-disable: bool, when present disable the tx delay > > Needs a vendor prefix. Indeed, and it would actually be nicer to allow specifying delays directly in ps units, see: Documentation/devicetree/bindings/net/dwmac-sun8i.txt Documentation/devicetree/bindings/net/mediatek-dwmac.txt for examples. -- Florian
