On Wednesday, March 19, 2014 12:12 AM, Tomasz Figa wrote: > On 18.03.2014 11:38, Cho KyongHo wrote: > > On Fri, 14 Mar 2014 14:28:36 +0100, Tomasz Figa wrote: > >> On 14.03.2014 06:05, Cho KyongHo wrote: > >>> This patch uses managed device helper functions in the probe(). > >>> > >>> Signed-off-by: Cho KyongHo <pullip.cho@xxxxxxxxxxx> > >>> --- > >>> drivers/iommu/exynos-iommu.c | 64 +++++++++++++++++------------------------- > >>> 1 file changed, 26 insertions(+), 38 deletions(-) > >>> > >>> diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c > >>> index 36e6b73..33b424d 100644 > >>> --- a/drivers/iommu/exynos-iommu.c > >>> +++ b/drivers/iommu/exynos-iommu.c [.....] > >>> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > >>> if (!res) { > >>> - dev_dbg(dev, "Unable to find IOMEM region\n"); > >>> - ret = -ENOENT; > >>> - goto err_init; > >>> + dev_err(dev, "Unable to find IOMEM region\n"); > >>> + return -ENOENT; > >>> } > >> > >> No need to check for error and print message, because > >> devm_ioremap_resource() already checks the passed resource and handles > >> error cases. > >> > > > > Yes but devm_ioremap_resource() just tells that the given 'res' is not > > correct. I think the message in the driver is more informative. > > The common practice used in Linux kernel is to not duplicate such > messages. It is obvious that devm_ioremap_resource() printing such > message is related to an IOMEM resource anyway, as you can't used it > with other types of resources. +1 I agree with Tomasz Figa's opinion. These messages have been being removed from Linux kernel. Thank you. Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html