On Wed, Mar 12, 2014 at 01:15:42PM -0700, Tim Kryger wrote: > Add the binding description for the Kona PWM controller found on Broadcom's > mobile SoCs. > > Signed-off-by: Tim Kryger <tim.kryger@xxxxxxxxxx> > Reviewed-by: Alex Elder <elder@xxxxxxxxxx> > Reviewed-by: Markus Mayer <markus.mayer@xxxxxxxxxx> > --- > .../devicetree/bindings/pwm/bcm-kona-pwm.txt | 24 ++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/bcm-kona-pwm.txt > > diff --git a/Documentation/devicetree/bindings/pwm/bcm-kona-pwm.txt b/Documentation/devicetree/bindings/pwm/bcm-kona-pwm.txt > new file mode 100644 > index 0000000..c8e2d13 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/bcm-kona-pwm.txt > @@ -0,0 +1,24 @@ > +Broadcom Kona PWM controller device tree bindings > + > +This controller has 6 channels. > + > +Required Properties : > +- compatible: should be "brcm,kona-pwm" This is somewhat inconsistent because the example below clearly doesn't set the compatible property to "brcm,kona-pwm". Perhaps better wording would be: - compatible: should contain "brcm,kona-pwm" > +- reg: physical base address and length of the controller's registers > +- clocks: phandle + clock specifier pair for the external clock > +- #pwm-cells: should be 3. The first cell specifies the per-chip index > + of the PWM to use, the second cell is the period in nanoseconds, and > + the third cell is the flags. Please use the canonical description for this: - #pwm-cells: Should be 3. See pwm.txt in this directory for a description of the cells format. > +Refer to pwm/pwm.txt for generic pwm controller node properties. With the above, this line should go away. But still: "pwm controller" -> "PWM controller". Thierry
Attachment:
pgpmARXqbNqMm.pgp
Description: PGP signature
