On Thu, Jan 3, 2019 at 5:41 PM Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx> wrote: > This commit simply renames gpio_set_drive_single_ended() to > gpio_set_config(), as the function is not specific to setting the GPIO > drive type, and will be used for other purposes in followup commits. > > In addition, it moves the function above gpiod_direction_input(), as > it will be used from gpiod_direction_input(). > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx> This is fine, but if you're factoring this config setting out then also change the lines in gpiod_set_debounce() and gpiod_set_transitory() to call the same helper. Yours, Linus Walleij
