Neil Armstrong <narmstrong@xxxxxxxxxxxx> writes: > On 08/12/2018 17:50, Martin Blumenstingl wrote: >> This adds the APB bus on Meson8 and Meson8b as well as the APB2 bus on >> Meson6. This is preparation work for adding the Mali GPU which is >> located on theses busses. >> >> Meson6 seems to have it's APB at 0xc8000000 instead of 0xd0000000. The >> region at 0xd0000000 is called APB2 or A9_APB and it has a different >> size (256k) compared to Meson8 and Meson8b (2M). >> >> Addresses and sizes are taken from the Amlogic 3.10 kernel sources: >> - Meson6: [0] >> - Meson8: [1] >> - Meson8b: [2] >> >> >> Changes since v1 at [3]: >> - re-send the patches but this time don't include the old patches >> which still had a typo in the patch description (ABP vs APB) >> >> >> [0] https://github.com/endlessm/linux-meson/blob/cd4096c3ff4eb5b8a8a5581bb46508601c5470dc/arch/arm/mach-meson6/include/mach/io.h#L61 >> [1] https://github.com/endlessm/linux-meson/blob/cd4096c3ff4eb5b8a8a5581bb46508601c5470dc/arch/arm/mach-meson8/include/mach/io.h#L53 >> [2] https://github.com/endlessm/linux-meson/blob/cd4096c3ff4eb5b8a8a5581bb46508601c5470dc/arch/arm/mach-meson8b/include/mach/io.h#L53 >> [3] http://lists.infradead.org/pipermail/linux-amlogic/2018-December/009424.html >> >> >> Martin Blumenstingl (3): >> ARM: dts: meson6: add the APB2 bus >> ARM: dts: meson8: add the APB bus >> ARM: dts: meson8b: add the APB bus >> >> arch/arm/boot/dts/meson6.dtsi | 8 ++++++++ >> arch/arm/boot/dts/meson8.dtsi | 8 ++++++++ >> arch/arm/boot/dts/meson8b.dtsi | 8 ++++++++ >> 3 files changed, 24 insertions(+) >> > > Reviewed-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx> > > But frankly I'll squash the meson8/meson8b patches with the mali node patches ! In general, I agree with Neil. Adding the new busses along with the series that uses them would be fine, but I don't have a strong preference. So queueing this series as is for v5.1 (branch: v5.1/dt) Kevin
