Hi, On Wed, Jan 9, 2019 at 4:29 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > Quoting Amit Kucheria (2019-01-09 16:00:55) > > 75 degrees is too aggressive for throttling the CPU. After speaking to > > Qualcomm engineers, increase it to 95 degrees. > > > > Signed-off-by: Amit Kucheria <amit.kucheria@xxxxxxxxxx> > > --- > > arch/arm64/boot/dts/qcom/sdm845.dtsi | 16 ++++++++-------- > > Is the plan that these are some defaults that would be adjusted by board > variants? Just curious why we have anything in here and don't punt it > all to each board dts file. My preference would be that the SoC device tree file should contain thermal numbers that are important to pay attention to for the safety / proper operation of the SoC. ...then individual boards could (if they needed to) override with lower values to control, for instance, skin temperature. >From experience with previous boards, if you've got enough an off-SoC thermistors then those are the ones you'd want to monitor to control skin temperature. It's OK if the SoC spikes up quite high as long as that heat has somewhere to go (like a heat pipe). The sensors that are part of Amit's patch are on-chip. ...if you've got a board without external thermistors and are using the SoC's on-chip sensors as a proxy for the heat in the overall system then you might want to lower your values in the board device tree file. You won't be able to have as many short term spikes, but that's what you gotta do without the extra sensors. Sound sane? -Doug
