Hi Enric, Am Donnerstag, 10. Januar 2019, 10:06:38 CET schrieb Enric Balletbo Serra: > Missatge de Rob Herring <robh@xxxxxxxxxx> del dia dj., 16 d’ag. 2018 a les 0:26: > > > > On Wed, Aug 15, 2018 at 11:59:34AM +0200, Enric Balletbo i Serra wrote: > > > This property is used when the otg-id pin is not connected. When this > > > property is set it forces to set the B-Device Session Valid bit when the > > > port works as device and clears that bit when the port works as host. > > > > > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx> > > > --- > > > > > > .../devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > > > index 2d4808d3920b..55761f466c41 100644 > > > --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > > > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > > > @@ -48,6 +48,11 @@ Optional properties: > > > See ./phy-bindings.txt for details. > > > - rockchip,utmi-avalid : boolean, use the avalid register to get vbus status. > > > Otherwise, use the bvalid register. > > > + - rockchip,force-bvalid : boolean, set this to force the B-Device Session > > > + Valid bit when the usb port is in device mode. This > > > + is used when the otg-id pin is not connected. > > > + Only supported in case of compatible being: > > > + * "rockchip,rk3399-usb2phy" > > > > Shouldn't you describe the property of the h/w that ID pin is not > > connected, rather than what you do with that information. > > > > What about "rockchip, otg-id-not-connected"? just pointing back to our discussion in patch3 about simply assuming id-not-connected in the case of the extcon missing I still think that might be the cleaner variant? But I guess you're probably already looking into doing that as so far you only resend the cleanup patches :-) . Heiko
