On Mon, Jan 07, 2019 at 01:41:30PM -0800, Stephen Boyd wrote: > Now this seems worse. We have gotten by without having to explicitly > list all the devices that are inside the PMIC as mfd cells. But now, to > avoid creating the irqs before the hierarchy is installed, we have to > undo all of that and rely on the difference in behavior of > of_platform_populate() and mfd_add_devices(). That's pretty obscure to > figure out. > > I'd prefer we drop this patch and keep disassociating virqs and > reassociating them in the gpio driver. Then we can remove the interrupts > properties in all the DTS files and finally remove the disassociate and > reassociating code in the gpio driver when all the DT files are cleaned > up. It makes things less confusing that way and doesn't require updates > to this driver. You are right that we can get this working without this patch. The issue that I experienced was caused by the interrupts property on the spmi-gpio node. I thought that I tested this with that configuration but I obviously didn't. qcom-pm8941.dtsi and qcom-pma8084.dtsi are the only two in-tree users of spmi-gpio. I'll include the fix for qcom-pma8084.dtsi as well. Brian
