On 2019/1/7 21:58, Guenter Roeck wrote: > On 1/7/19 3:00 AM, Xiaoting Liu wrote: >> Bindings for DPS650AB power, voltage, temperature, and fan monitering. >> >> Signed-off-by: Xiaoting Liu <xiaoting.liu@xxxxxxxxxxxxxxxx> >> --- >> v2: >> Change the patch subject. >> --- >> Documentation/devicetree/bindings/hwmon/dps650ab.txt | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/hwmon/dps650ab.txt b/Documentation/devicetree/bindings/hwmon/dps650ab.txt >> new file mode 100644 >> index 000000000000..6bbbff89f6d5 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/hwmon/dps650ab.txt >> @@ -0,0 +1,11 @@ >> +Bindings for DPS650AB power, voltage, temperature, and fan monitering >> + > Assuming this is the Delta Electronics DPS-650-AB power supply, I think > you should mention that here. I will update commit message as mentioned. > >> +Required properties: >> +- compatible : "dps650ab" > Again, assuming this is the Delta Electronics power supply, this should > probably be something like "delta,dps650ab". OK, I will add delta to compatible property. Thanks, Xiaoting > > Thanks, > Guenter > >> +- reg : I2C address, one of 0x58, 0x59. >> + >> +Example: >> + dps650ab@58 { >> + compatible = "dps650ab"; >> + reg = <0x58>; >> + }; >> -- >> 1.8.3.1 >> >> >> >>