* Rob Herring <robh@xxxxxxxxxx> [190107 18:37]: > On Mon, Jan 7, 2019 at 11:59 AM Tony Lindgren <tony@xxxxxxxxxxx> wrote: > > > > We're now getting the following error: > > > > genirq: Setting trigger mode 1 for irq 230 failed > > (regmap_irq_set_type+0x0/0x15c) > > cpcap-usb-phy cpcap-usb-phy.0: could not get irq dp: -524 > > > > This is because of a typo in the irq flags. Really these interrupts > > are LEVEL, but before we change them we need to test them. So let's > > do a minimal fix first. > > Hopefully, you mean a driver fix later and not changing the DT again? > A 0 flag is correct if the type is not programmable which I'd guess is > the case here. Oh OK thanks for letting me know. In that case with 0 being correct for non-programmable interrupts, I'll just drop that paragraph and no need for further changes. The driver should be already doing the right thing. Regards, Tony
