2019年1月7日(月) 20:27 Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>: > > Hi Mita-san, > > On Sun, Dec 23, 2018 at 02:12:51AM +0900, Akinobu Mita wrote: > > Register a sub-device to the asynchronous subdevice framework, and also > > create subdevice device node. > > > > Cc: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> > > Cc: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx> > > Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx> > > --- > > drivers/media/i2c/Kconfig | 2 +- > > drivers/media/i2c/mt9m001.c | 9 ++++++++- > > 2 files changed, 9 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > > index 5e30ad3..a6d8416 100644 > > --- a/drivers/media/i2c/Kconfig > > +++ b/drivers/media/i2c/Kconfig > > @@ -845,7 +845,7 @@ config VIDEO_VS6624 > > > > config VIDEO_MT9M001 > > tristate "mt9m001 support" > > - depends on I2C && VIDEO_V4L2 > > + depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API > > VIDEO_V4L2_SUBDEV_API depends on MEDIA_CONTROLLER, so MEDIA_CONTROLLER > below can be removed. OK. > > depends on MEDIA_CAMERA_SUPPORT > > depends on MEDIA_CONTROLLER > > help > > diff --git a/drivers/media/i2c/mt9m001.c b/drivers/media/i2c/mt9m001.c > > index e31fb7d..b4deec3 100644 > > --- a/drivers/media/i2c/mt9m001.c > > +++ b/drivers/media/i2c/mt9m001.c > > @@ -716,6 +716,7 @@ static int mt9m001_probe(struct i2c_client *client, > > return PTR_ERR(mt9m001->reset_gpio); > > > > v4l2_i2c_subdev_init(&mt9m001->subdev, client, &mt9m001_subdev_ops); > > + mt9m001->subdev.flags = V4L2_SUBDEV_FL_HAS_DEVNODE; > > |= > > Otherwise you lose flags set by v4l2_i2c_subdev_init(). Oops. Thanks for spotting.
