On Fri, 14 Mar 2014 20:52:43 +0530, Sachin Kamat wrote: > Hi KyongHo, > > On 14 March 2014 10:35, Cho KyongHo <pullip.cho@xxxxxxxxxxx> wrote: > > This patch uses managed device helper functions in the probe(). > > > > Signed-off-by: Cho KyongHo <pullip.cho@xxxxxxxxxxx> > > --- > [snip] > > > + data->clk = devm_clk_get(dev, "sysmmu"); > > + if (IS_ERR(data->clk)) { > > + dev_info(dev, "No gate clock found!\n"); > > + data->clk = NULL; > > + } > > Why aren't you returning from here upon error? It is for the case of a System MMU which does not need clock gating. > > + > > + ret = clk_prepare(data->clk); > > + if (ret) { > > + dev_err(dev, "Failed to prepare clk\n"); > > + return ret; > > } > > > > data->sysmmu = dev; > > @@ -556,17 +553,8 @@ static int exynos_sysmmu_probe(struct platform_device *pdev) > > > > pm_runtime_enable(dev); > > > > - dev_dbg(dev, "Initialized\n"); > > + dev_dbg(dev, "Probed and initialized\n"); > > This message looks redundant. Ok. Do you mean that checking sysfs does the same? Thank you. KyongHo. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html