On Thu, 2019-01-03 at 12:45 -0600, Rob Herring wrote: > On Wed, Jan 2, 2019 at 8:10 AM Henry Chen <henryc.chen@xxxxxxxxxxxx> wrote: > > > > Add opp table on scpsys dt-bindings for Mediatek SoC. > > > > Signed-off-by: Henry Chen <henryc.chen@xxxxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/opp/mtk-opp.txt | 24 +++++++++++++ > > .../devicetree/bindings/soc/mediatek/scpsys.txt | 42 ++++++++++++++++++++++ > > 2 files changed, 66 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/opp/mtk-opp.txt > > > > diff --git a/Documentation/devicetree/bindings/opp/mtk-opp.txt b/Documentation/devicetree/bindings/opp/mtk-opp.txt > > new file mode 100644 > > index 0000000..036be1c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/opp/mtk-opp.txt > > @@ -0,0 +1,24 @@ > > +Mediatek OPP bindings to descibe OPP nodes with level values > > + > > +OPP tables for devices on Mediatek platforms require an additional > > +platform specific level value to be specified. > > +This value is passed on to the mediatek Power Management Unit by the > > +CPU, which then takes the necessary actions to set a voltage rail > > +to an appropriate voltage based on the value passed. > > + > > +The bindings are based on top of the operating-points-v2 bindings > > +described in Documentation/devicetree/bindings/opp/opp.txt > > +Additional properties are described below. > > + > > +* OPP Table Node > > + > > +Required properties: > > +- compatible: Allow OPPs to express their compatibility. It should be: > > + "operating-points-v2-mtk-level" > > + > > +* OPP Node > > + > > +Required properties: > > +- mtk,level: On Mediatek platforms an OPP node can describe a positive value > > +representing a level that's communicated with a our power management hardware > > +which then translates it into a certain voltage on a voltage rail. > > Work with the Qcom folks and create a common level property. > > Rob Ok, I see the reply from Rajendra on https://lore.kernel.org/patchwork/patch/1027082/ I will follow the new common property, thanks.