> Subject: Re: [PATCH 2/3] Documentation: DT: Add entry for DPAA2 console > > On Fri, Dec 21, 2018 at 03:31:11PM +0000, Ioana Ciornei wrote: > > This patch adds a devicetree binding documentation for FSL's DPAA2 > > console. > > > > Signed-off-by: Ioana Ciornei <ioana.ciornei@xxxxxxx> > > --- > > Documentation/devicetree/bindings/misc/dpaa2-console.txt | 11 > +++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 12 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/misc/dpaa2-console.txt > > > > diff --git a/Documentation/devicetree/bindings/misc/dpaa2-console.txt > > b/Documentation/devicetree/bindings/misc/dpaa2-console.txt > > new file mode 100644 > > index 0000000..f4e16b1 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/misc/dpaa2-console.txt > > @@ -0,0 +1,11 @@ > > +DPAA2 console support > > + > > +Required properties: > > + > > + - compatible > > + Value type: <string> > > + Definition: Must be "dpaa2-console". > > + - reg > > + Value type: <prop-encoded-array> > > + Definition: A standard property. Specifies the region where the MCFBA > > + (MC firmware base address) register can be found. > > What's the relationship between MCFBA and the console? The console is basically a log buffer of the MC firmware, and is found at a known offset compared to the firmware image's runtime base address. > The binding should describe the h/w block or firmware interface not the feature you want to > implement. Are there other functions provided by the MC firmware? The MC firmware manages all hardware resources related to networking or any other accelerators. Any interaction with the firmware is made through commands put in memory mapped regions. The fsl-mc bus driver is the one that already manages this interaction with the MC. Ioana > > Rob
