On Thu, Jan 3, 2019 at 9:59 AM Viorel Suman <viorel.suman@xxxxxxx> wrote: > > Hi Nicolin, > > Thank you for your feedback, same here - just back from vacation. > > On Jo, 2018-12-27 at 01:24 +0800, Nicolin Chen wrote: > > Hi Viorel, > > > > Sorry for the late response, having been on a long vacation. > > > > The code looks pretty clean. Just some small concerns/questions > > below. > > > > On Wed, Dec 19, 2018 at 12:30 AM Viorel Suman <viorel.suman@xxxxxxx> > > wrote: > > > > > > > > > This patch implements Audio Mixer CPU DAI driver for NXP iMX8 SOCs. > > > The Audio Mixer is a on-chip functional module that allows mixing > > > of > > > two audio streams into a single audio stream. > > > > > > Audio Mixer datasheet is available here: > > > https://www.nxp.com/docs/en/reference-manual/IMX8DQXPRM.pdf > > > > > > Signed-off-by: Viorel Suman <viorel.suman@xxxxxxx> > > > --- > > > .../devicetree/bindings/sound/fsl,amix.txt | 45 ++ > > > sound/soc/fsl/Kconfig | 7 + > > > sound/soc/fsl/Makefile | 3 + > > > sound/soc/fsl/fsl_amix.c | 554 > > > +++++++++++++++++++++ > > > sound/soc/fsl/fsl_amix.h | 101 ++++ > > I aimn't against the naming here, but it seems to be AUDMIX in RM? > > > > Would it be better to align with that? It's your decision though. > > To me "AUDMIX" sounds more like some RTL high level integration module, > I would prefer to keep it as it is if there is no strong reason to > rename it. At least for compatible string names, matching what's in the RM or RTL is more appropriate. Where does "AMIX" come from? Rob
