Re: [PATCH 2/3] mmc: sdhci-esdhc-imx: add SD clock limitation for imx6ull

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi BOUGH,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on ulf.hansson-mmc/next]
[also build test WARNING on v4.20-rc7 next-20181221]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/BOUGH-CHEN/dt-bindings-mmc-fsl-imx-esdhc-add-imx6ull-compatible-string/20181223-011123
base:   git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git next
config: arm-imx_v6_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=arm 

All warnings (new ones prefixed by >>):

   drivers/mmc/host/sdhci-esdhc-imx.c:1511:24: error: initializer element is not constant
    module_platform_driver(sdhci_esdhc_imx_driver);
                           ^
   include/linux/init.h:195:50: note: in definition of macro '___define_initcall'
      __attribute__((__section__(#__sec ".init"))) = fn;
                                                     ^~
   include/linux/init.h:227:30: note: in expansion of macro '__define_initcall'
    #define device_initcall(fn)  __define_initcall(fn, 6)
                                 ^~~~~~~~~~~~~~~~~
   include/linux/init.h:232:24: note: in expansion of macro 'device_initcall'
    #define __initcall(fn) device_initcall(fn)
                           ^~~~~~~~~~~~~~~
   include/linux/module.h:87:24: note: in expansion of macro '__initcall'
    #define module_init(x) __initcall(x);
                           ^~~~~~~~~~
   include/linux/device.h:1615:1: note: in expansion of macro 'module_init'
    module_init(__driver##_init); \
    ^~~~~~~~~~~
   include/linux/platform_device.h:229:2: note: in expansion of macro 'module_driver'
     module_driver(__platform_driver, platform_driver_register, \
     ^~~~~~~~~~~~~
   drivers/mmc/host/sdhci-esdhc-imx.c:1511:1: note: in expansion of macro 'module_platform_driver'
    module_platform_driver(sdhci_esdhc_imx_driver);
    ^~~~~~~~~~~~~~~~~~~~~~
   In file included from include/linux/mmc/host.h:14:0,
                    from drivers/mmc/host/sdhci-esdhc-imx.c:17:
   drivers/mmc/host/sdhci-esdhc-imx.c:1511:24: error: invalid storage class for function 'sdhci_esdhc_imx_driver_exit'
    module_platform_driver(sdhci_esdhc_imx_driver);
                           ^
   include/linux/device.h:1616:20: note: in definition of macro 'module_driver'
    static void __exit __driver##_exit(void) \
                       ^~~~~~~~
   drivers/mmc/host/sdhci-esdhc-imx.c:1511:1: note: in expansion of macro 'module_platform_driver'
    module_platform_driver(sdhci_esdhc_imx_driver);
    ^~~~~~~~~~~~~~~~~~~~~~
   include/linux/device.h:1616:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
    static void __exit __driver##_exit(void) \
    ^
   include/linux/platform_device.h:229:2: note: in expansion of macro 'module_driver'
     module_driver(__platform_driver, platform_driver_register, \
     ^~~~~~~~~~~~~
   drivers/mmc/host/sdhci-esdhc-imx.c:1511:1: note: in expansion of macro 'module_platform_driver'
    module_platform_driver(sdhci_esdhc_imx_driver);
    ^~~~~~~~~~~~~~~~~~~~~~
   In file included from include/linux/io.h:22:0,
                    from drivers/mmc/host/sdhci-esdhc-imx.c:11:
   drivers/mmc/host/sdhci-esdhc-imx.c:1511:24: error: initializer element is not constant
    module_platform_driver(sdhci_esdhc_imx_driver);
                           ^
   include/linux/init.h:235:50: note: in definition of macro '__exitcall'
     static exitcall_t __exitcall_##fn __exit_call = fn
                                                     ^~
   include/linux/device.h:1620:1: note: in expansion of macro 'module_exit'
    module_exit(__driver##_exit);
    ^~~~~~~~~~~
   include/linux/platform_device.h:229:2: note: in expansion of macro 'module_driver'
     module_driver(__platform_driver, platform_driver_register, \
     ^~~~~~~~~~~~~
   drivers/mmc/host/sdhci-esdhc-imx.c:1511:1: note: in expansion of macro 'module_platform_driver'
    module_platform_driver(sdhci_esdhc_imx_driver);
    ^~~~~~~~~~~~~~~~~~~~~~
   In file included from include/linux/module.h:18:0,
                    from drivers/mmc/host/sdhci-esdhc-imx.c:15:
   include/linux/moduleparam.h:28:3: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
      struct __UNIQUE_ID(name) {}
      ^
   include/linux/module.h:161:32: note: in expansion of macro '__MODULE_INFO'
    #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info)
                                   ^~~~~~~~~~~~~
   include/linux/module.h:208:42: note: in expansion of macro 'MODULE_INFO'
    #define MODULE_DESCRIPTION(_description) MODULE_INFO(description, _description)
                                             ^~~~~~~~~~~
   drivers/mmc/host/sdhci-esdhc-imx.c:1513:1: note: in expansion of macro 'MODULE_DESCRIPTION'
    MODULE_DESCRIPTION("SDHCI driver for Freescale i.MX eSDHC");
    ^~~~~~~~~~~~~~~~~~
   In file included from <command-line>:0:0:
   include/linux/compiler-gcc.h:75:45: error: expected declaration or statement at end of input
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                                ^
   include/linux/compiler_types.h:53:23: note: in definition of macro '___PASTE'
    #define ___PASTE(a,b) a##b
                          ^
   include/linux/compiler-gcc.h:75:29: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                ^~~~~~~
   include/linux/compiler_types.h:54:22: note: in expansion of macro '___PASTE'
    #define __PASTE(a,b) ___PASTE(a,b)
                         ^~~~~~~~
   include/linux/compiler-gcc.h:75:37: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                        ^~~~~~~
   include/linux/moduleparam.h:28:10: note: in expansion of macro '__UNIQUE_ID'
      struct __UNIQUE_ID(name) {}
             ^~~~~~~~~~~
   include/linux/module.h:161:32: note: in expansion of macro '__MODULE_INFO'
    #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info)
                                   ^~~~~~~~~~~~~
   include/linux/module.h:199:34: note: in expansion of macro 'MODULE_INFO'
    #define MODULE_LICENSE(_license) MODULE_INFO(license, _license)
                                     ^~~~~~~~~~~
>> drivers/mmc/host/sdhci-esdhc-imx.c:1515:1: note: in expansion of macro 'MODULE_LICENSE'
    MODULE_LICENSE("GPL v2");
    ^~~~~~~~~~~~~~

vim +/MODULE_LICENSE +1515 drivers/mmc/host/sdhci-esdhc-imx.c

85d6509dc8 Shawn Guo    2011-05-27  1512  
85d6509dc8 Shawn Guo    2011-05-27  1513  MODULE_DESCRIPTION("SDHCI driver for Freescale i.MX eSDHC");
035ff831cd Wolfram Sang 2015-04-20  1514  MODULE_AUTHOR("Wolfram Sang <kernel@xxxxxxxxxxxxxx>");
85d6509dc8 Shawn Guo    2011-05-27 @1515  MODULE_LICENSE("GPL v2");

:::::: The code at line 1515 was first introduced by commit
:::::: 85d6509dc8ca24b2b652863ef7a75622ddca17d6 mmc: sdhci: make sdhci-pltfm device drivers self registered

:::::: TO: Shawn Guo <shawn.guo@xxxxxxxxxx>
:::::: CC: Chris Ball <cjb@xxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux