Hi Tudor, > -----Original Message----- > From: Tudor.Ambarus@xxxxxxxxxxxxx [mailto:Tudor.Ambarus@xxxxxxxxxxxxx] > Sent: Tuesday, December 11, 2018 1:40 PM > To: Yogesh Narayan Gaur <yogeshnarayan.gaur@xxxxxxx>; linux- > mtd@xxxxxxxxxxxxxxxxxxx; boris.brezillon@xxxxxxxxxxx; broonie@xxxxxxxxxx; > marek.vasut@xxxxxxxxx; vigneshr@xxxxxx; linux-spi@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx > Cc: robh@xxxxxxxxxx; mark.rutland@xxxxxxx; shawnguo@xxxxxxxxxx; linux- > arm-kernel@xxxxxxxxxxxxxxxxxxx; computersforpeace@xxxxxxxxx; > frieder.schrempf@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v5 3/7] mtd: spi-nor: add opcodes for octal Read/Write > commands > > Hi, > > On 12/11/2018 06:55 AM, Yogesh Narayan Gaur wrote: > > Thus would going to modify the condition check as below, so that SFDP > parsing would also be performed when SPI_NOR_OCTAL_READ is set. Correct? > > > > if ((info->flags & (SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | > > SPI_NOR_OCTAL_READ)) && !(info->flags & > > SPI_NOR_SKIP_SFDP)) { > > Yes, this is what I was suggesting. On a second thought, we haven't added yet > support for parsing sfdp to get the octal mode info, so the parsing will be done > gratuitously. Let's drop this change and add it when adding support for parsing > octal mode info from sfdp. I'll prepare a patch for this. > > Please rebase on top of spi-nor/next, s/octo/octal in spi-nor.h and correct your > S-o-b tag and you'll have my R-b tag. > Next version, v6, sent for review[1]. Sorry for late reply, was on leave. -- Regards Yogesh Gaur [1] https://patchwork.ozlabs.org/project/linux-mtd/list/?series=82815 > Thanks Yogesh, > ta
