Hi, Alexandre Best Regards! Anson Huang > -----Original Message----- > From: Alexandre Belloni [mailto:alexandre.belloni@xxxxxxxxxxx] > Sent: 2018年12月19日 16:54 > To: Anson Huang <anson.huang@xxxxxxx> > Cc: a.zummo@xxxxxxxxxxxx; robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; > catalin.marinas@xxxxxxx; will.deacon@xxxxxxx; Aisheng Dong > <aisheng.dong@xxxxxxx>; Andy Gross <andy.gross@xxxxxxxxxx>; > arnd@xxxxxxxx; horms+renesas@xxxxxxxxxxxx; heiko@xxxxxxxxx; > bjorn.andersson@xxxxxxxxxx; enric.balletbo@xxxxxxxxxxxxx; > amit.kucheria@xxxxxxxxxx; ezequiel@xxxxxxxxxxxxx; olof@xxxxxxxxx; > LW@xxxxxxxxxxxxxxxxxxx; shawnguo@xxxxxxxxxx; linux-rtc@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx> > Subject: Re: [PATCH V4 2/4] rtc: add i.MX system controller RTC support > > Hello, > > On 29/11/2018 01:50:11+0000, Anson Huang wrote: > > i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller > > inside, the system controller is in charge of controlling power, clock > > and secure rtc etc.. > > > > This patch adds i.MX system controller RTC driver support, Linux > > kernel has to communicate with system controller via MU (message unit) > > IPC to set/get RTC time and other alarm functions, since the RTC set > > time needs to be done in secure EL3 mode (required by system > > controller firmware) and alarm functions needs to be done with general > > MU IRQ handle, these depend on other components which are NOT ready, > > so this patch ONLY enables the RTC time read. > > > > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx> > > --- > > ChangeLog: > > V3->V4: > > *remove unnecessary headfile included; > > *fix potential memory currpution for the message responce; > > *update the compatible string name to start with "fsl" instead of "nxp". > > drivers/rtc/Kconfig | 6 +++ > > drivers/rtc/Makefile | 1 + > > drivers/rtc/rtc-imx-sc.c | 98 > > ++++++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 105 insertions(+) > > create mode 100644 drivers/rtc/rtc-imx-sc.c > > > > I applied it on my test branch and this makes sparc64-allyesconfig fail > with: > > drivers/rtc/rtc-imx-sc.o: In function `imx_sc_rtc_read_time': > rtc-imx-sc.c:(.text+0x34): undefined reference to `imx_scu_call_rpc' > drivers/rtc/rtc-imx-sc.o: In function `imx_sc_rtc_probe': > rtc-imx-sc.c:(.text+0x90): undefined reference to `imx_scu_get_handle' Maybe there are some changes on basic support of imx scu driver, I will resend a patch set later, thanks. Anson. > > > > -- > Alexandre Belloni, Bootlin > Embedded Linux and Kernel engineering > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootl > in.com&data=02%7C01%7Canson.huang%40nxp.com%7C72b147643a3f > 44c258c208d6658f9cce%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0 > %7C636808064818797711&sdata=%2Bl5jGXX6wBYbOg5Zalg4CyxyZKjUe > uzRSQEKO9TJnRI%3D&reserved=0
