[Cc: += linux-pwm] Hello, On Wed, Dec 19, 2018 at 05:41:31AM +0000, Anson Huang wrote: > From i.MX6SL Reference Manual, the PWMx's ipg clock > for registers access is from perclk, correct them. I assume this is related to the patch "pwm: imx: add ipg clock operation"? This patch doesn't fix a real problem because in practise perclk is already enabled, right? (I don't question the patch, just wonder how urgent it is.) > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx> > --- > arch/arm/boot/dts/imx6sl.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi > index e7524e7..4b4813f 100644 > --- a/arch/arm/boot/dts/imx6sl.dtsi > +++ b/arch/arm/boot/dts/imx6sl.dtsi > @@ -338,7 +338,7 @@ > compatible = "fsl,imx6sl-pwm", "fsl,imx27-pwm"; > reg = <0x02080000 0x4000>; > interrupts = <0 83 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&clks IMX6SL_CLK_PWM1>, > + clocks = <&clks IMX6SL_CLK_PERCLK>, > <&clks IMX6SL_CLK_PWM1>; > clock-names = "ipg", "per"; It's a bit irritating that IMX6SL_CLK_PERCLK is used for the "ipg" clk, not the "per" clk. Is this correct? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
