Re: [PATCH v2 net-next 06/10] net: eth: altera: Add missing identifier names to function declarations

[Thor Thayer <thor.thayer@xxxxxxxxxxxxxxx>]

Hi Dalon,

On 12/13/18 11:52 AM, dwesterg@xxxxxxxxx wrote:
> From: Dalon Westergreen <dalon.westergreen@xxxxxxxxxxxxxxx>
>
> The sgdma and msgdma header files included function declarations
> without identifier names for pointers.  Add appropriate identifier
> names.
>
> Signed-off-by: Dalon Westergreen <dalon.westergreen@xxxxxxxxxxxxxxx>
> ---
>   drivers/net/ethernet/altera/altera_msgdma.h | 30 ++++++++++---------
>   drivers/net/ethernet/altera/altera_sgdma.h  | 32 +++++++++++----------
>   2 files changed, 33 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/net/ethernet/altera/altera_msgdma.h b/drivers/net/ethernet/altera/altera_msgdma.h
> index 42cf61c81057..e18be91a48a7 100644
> --- a/drivers/net/ethernet/altera/altera_msgdma.h
> +++ b/drivers/net/ethernet/altera/altera_msgdma.h
> @@ -17,19 +17,21 @@
>   #ifndef __ALTERA_MSGDMA_H__
>   #define __ALTERA_MSGDMA_H__
>   
> -void msgdma_reset(struct altera_tse_private *);
> -void msgdma_enable_txirq(struct altera_tse_private *);
> -void msgdma_enable_rxirq(struct altera_tse_private *);
> -void msgdma_disable_rxirq(struct altera_tse_private *);
> -void msgdma_disable_txirq(struct altera_tse_private *);
> -void msgdma_clear_rxirq(struct altera_tse_private *);
> -void msgdma_clear_txirq(struct altera_tse_private *);
> -u32 msgdma_tx_completions(struct altera_tse_private *);
> -void msgdma_add_rx_desc(struct altera_tse_private *, struct tse_buffer *);
> -int msgdma_tx_buffer(struct altera_tse_private *, struct tse_buffer *);
> -u32 msgdma_rx_status(struct altera_tse_private *);
> -int msgdma_initialize(struct altera_tse_private *);
> -void msgdma_uninitialize(struct altera_tse_private *);
> -void msgdma_start_rxdma(struct altera_tse_private *);
> +void msgdma_reset(struct altera_tse_private *priv);
> +void msgdma_enable_txirq(struct altera_tse_private *priv);
> +void msgdma_enable_rxirq(struct altera_tse_private *priv);
> +void msgdma_disable_rxirq(struct altera_tse_private *priv);
> +void msgdma_disable_txirq(struct altera_tse_private *priv);
> +void msgdma_clear_rxirq(struct altera_tse_private *priv);
> +void msgdma_clear_txirq(struct altera_tse_private *priv);
> +u32 msgdma_tx_completions(struct altera_tse_private *priv);
> +void msgdma_add_rx_desc(struct altera_tse_private *priv,
> +			struct tse_buffer *buffer);
> +int msgdma_tx_buffer(struct altera_tse_private *priv,
> +		     struct tse_buffer *buffer);
> +u32 msgdma_rx_status(struct altera_tse_private *priv);
> +int msgdma_initialize(struct altera_tse_private *priv);
> +void msgdma_uninitialize(struct altera_tse_private *priv);
> +void msgdma_start_rxdma(struct altera_tse_private *priv);
>   
>   #endif /*  __ALTERA_MSGDMA_H__ */
> diff --git a/drivers/net/ethernet/altera/altera_sgdma.h b/drivers/net/ethernet/altera/altera_sgdma.h
> index 584977e29ef9..769e720a2043 100644
> --- a/drivers/net/ethernet/altera/altera_sgdma.h
> +++ b/drivers/net/ethernet/altera/altera_sgdma.h
> @@ -17,20 +17,22 @@
>   #ifndef __ALTERA_SGDMA_H__
>   #define __ALTERA_SGDMA_H__
>   
> -void sgdma_reset(struct altera_tse_private *);
> -void sgdma_enable_txirq(struct altera_tse_private *);
> -void sgdma_enable_rxirq(struct altera_tse_private *);
> -void sgdma_disable_rxirq(struct altera_tse_private *);
> -void sgdma_disable_txirq(struct altera_tse_private *);
> -void sgdma_clear_rxirq(struct altera_tse_private *);
> -void sgdma_clear_txirq(struct altera_tse_private *);
> -int sgdma_tx_buffer(struct altera_tse_private *priv, struct tse_buffer *);
> -u32 sgdma_tx_completions(struct altera_tse_private *);
> -void sgdma_add_rx_desc(struct altera_tse_private *priv, struct tse_buffer *);
> -void sgdma_status(struct altera_tse_private *);
> -u32 sgdma_rx_status(struct altera_tse_private *);
> -int sgdma_initialize(struct altera_tse_private *);
> -void sgdma_uninitialize(struct altera_tse_private *);
> -void sgdma_start_rxdma(struct altera_tse_private *);
> +void sgdma_reset(struct altera_tse_private *priv);
> +void sgdma_enable_txirq(struct altera_tse_private *priv);
> +void sgdma_enable_rxirq(struct altera_tse_private *priv);
> +void sgdma_disable_rxirq(struct altera_tse_private *priv);
> +void sgdma_disable_txirq(struct altera_tse_private *priv);
> +void sgdma_clear_rxirq(struct altera_tse_private *priv);
> +void sgdma_clear_txirq(struct altera_tse_private *priv);
> +int sgdma_tx_buffer(struct altera_tse_private *priv,
> +		    struct tse_buffer *buffer);
> +u32 sgdma_tx_completions(struct altera_tse_private *priv);
> +void sgdma_add_rx_desc(struct altera_tse_private *priv,
> +		       struct tse_buffer *buffer);
> +void sgdma_status(struct altera_tse_private *priv);
> +u32 sgdma_rx_status(struct altera_tse_private *priv);
> +int sgdma_initialize(struct altera_tse_private *priv);
> +void sgdma_uninitialize(struct altera_tse_private *priv);
> +void sgdma_start_rxdma(struct altera_tse_private *priv);
>   
>   #endif /*  __ALTERA_SGDMA_H__ */

FYI. Since this is a change in v2, there is normally a break below your 
Signed-off-by and then a description of what changed (in this case new 
patch). This isolates the changes to the patch even though you put it in 
the summary patch. So it would look like this

<snip>
>
> Signed-off-by: Dalon Westergreen <dalon.westergreen@xxxxxxxxxxxxxxx>
> ---
> v2 New patch cleanup that adds the pointer identifier names.
> ---
>   drivers/net/ethernet/altera/altera_msgdma.h | 30 ++++++++++---------
>   drivers/net/ethernet/altera/altera_sgdma.h  | 32 +++++++++++----------
</snip>

Acked-by: Thor Thayer <thor.thayer@xxxxxxxxxxxxxxx>