On Fri, Dec 14, 2018 at 11:46:02AM -0600, Rob Herring wrote: > On Fri, Dec 14, 2018 at 3:36 AM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote: > > > > On Tue, Dec 11, 2018 at 2:15 PM Heikki Krogerus > > <heikki.krogerus@xxxxxxxxxxxxxxx> wrote: > > > > > > This implements get_name fwnode op for DT. > > > > > > Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > > > > Rob, any objections here? > > Yes, what I said in v5. I did address your comment in v5? The helper no longer tries to read "name" property if the callback fails. > At one point this series had a user which was finding a matching node > by name. Now there is no user, so I can't really say whether this API > makes sense or not. That is a fair point. I choose to not to convert fwnode_get_named_child_node() to use this helper because it would mean we would have to allocate the buffer there, and I don't know if it's worth it. Let's forget about this for now. I was planning to use this helper for matching a requested remote-endpoint (graph) device, but I'm not sure if the node name is usable there. I'll resend these as part of a real user for the API, if I ever have one. thanks, -- heikki
