On 12/13/18, 2:56 PM, "Joel Stanley" <joel@xxxxxxxxx> wrote: On Fri, 14 Dec 2018 at 06:23, Vijay Khemka <vijaykhemka@xxxxxx> wrote: > > Added ADC and other sensor devices in Facebook Tiogapass device tree. > > Signed-off-by: Vijay Khemka <vijaykhemka@xxxxxx> > --- > .../dts/aspeed-bmc-facebook-tiogapass.dts | 33 +++++++++++++++++-- > 1 file changed, 31 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts > index f8e7b71af7e6..58bbe08d3ba7 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts > @@ -21,6 +21,25 @@ > memory@80000000 { > reg = <0x80000000 0x20000000>; > }; > + > + iio-hwmon { > + compatible = "iio-hwmon"; > + oemname0 = "MB_P3V3"; > + oemname1 = "MB_P5V"; > + oemname2 = "MB_P12V"; > + oemname3 = "MB_P1V05"; > + oemname4 = "MB_PVNN_PCH_STBY"; > + oemname5 = "MB_P3V3_STBY"; > + oemname6 = "MB_P5V_STBY"; "oemname" isn't part of the upstream bindings. Is this something you have patches for? This is a workaround field used by dbus-sensors application to avoid overlay for dynamic detection of devices based on json file definition. Can you please also review other 3 patches in this series.