Hi Fabrizio, On Thu, Dec 13, 2018 at 9:21 PM Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> wrote: > Add PCIe support for the RZ/G2E (a.k.a. R8A774C0). > > Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> One question below. > --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt > +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt > @@ -37,7 +39,8 @@ compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC; > > Optional properties: > - phys: from common PHY binding: PHY phandle and specifier (only make sense > - for R-Car gen3 SoCs where the PCIe PHYs have their own register blocks). > + for R-Car gen3 and RZ/G2 SoCs where the PCIe PHYs have their own Gen3, while at it? > + register blocks). The RZ/G2 Hardware User Manual I have lacks the table specifying which SoCs have which PHY registers. So I cannot verify if the above paragraph applies to RZ/G2(E). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds