Dear Andrew, Thanks for your comments. On Thu, 2018-12-13 at 13:36 +0100, Andrew Lunn wrote: > > +- mediatek,rx-delay-ps: RX clock delay macro value. Default is 0. > > + It should be defined for rgmii/rgmii-txid/mii/rmii interface. > > +Both delay properties need to be a multiple of 170 for fine-tune rgmii, > > +range 0~31*170. > > +Both delay properties need to be a multiple of 550 for coarse-tune rgmii, > > +range 0~31*550. > > +Both delay properties need to be a multiple of 550 for mii/rmii, > > +range 0~31*550. > > You see "need to be" here, but the driver does not care. It will round > down. Please either make the driver check, or change the text to > rather say it will round down. OK, will mark "round down" in the binding file. > > Andrew
