On Wed, Dec 12, 2018 at 09:31:26PM +0200, Timo Alho wrote: > > static bool tegra_bpmp_is_req_ready(struct tegra_bpmp_channel *channel) > { > - return tegra_bpmp_is_resp_ready(channel); > + struct tegra_bpmp *bpmp = channel->bpmp; > + > + return bpmp->soc->ops->is_req_ready(channel); Perhaps, write a helper function to return ops pointer from channel and use it here and below? > > +extern struct tegra_bpmp_ops tegra186_bpmp_ops; Move this to bpmp-private.h?