Hi Anson, On Wed, Dec 12, 2018 at 4:17 AM Anson Huang <anson.huang@xxxxxxx> wrote: > > Hi, Fabio > Obviously, some of the dts files (such as arch/arm/boot/dts/exynos5420-peach-pit.dts) using "vcc" as isl29018's power supply name, they are NOT matched with datasheet, so should we update those dts files with "vdd" as well or just using the "vcc" in isl29018 driver? Which solution is better? We should not break existing dtbs, so in this case just keep the existing supply name and you could add the new optional vdda supply as per the datasheet.