On 12/12/18 11:02, Greg KH wrote:
On Fri, Dec 07, 2018 at 04:35:10PM +0000, Srinivas Kandagatla wrote:
+#define FASTRPC_BUILD_SCALARS(attr, method, in, out, oin, oout) \
+ ((((uint32_t) (attr) & 0x07) << 29) | \
+ (((uint32_t) (method) & 0x1f) << 24) | \
Why all of the uint32_t and uint64_t types in this patch, but not the
previous one?
Please just stick with u32 and u64, those are the correct kernel types
to be using everywhere. uint32_t and friends are userspace things that
make no sense in kernel space.
Yes, I know people use them, but we should not be adding to the problem
by creating new instances of them for no good reason.
Thanks for the feedback, Sure I will revisit and cleanup such instances!
--srini
thanks,
greg k-h
