On Thu, 13 Mar 2014 14:51:56 -0700, Kevin Hilman <khilman@xxxxxxxxxx> wrote: > Josh Cartwright <joshc@xxxxxxxxxxxxxx> writes: > > > On Thu, Mar 13, 2014 at 01:46:50PM -0700, Kevin Hilman wrote: > >> On Fri, Feb 21, 2014 at 4:25 AM, Marek Szyprowski > >> <m.szyprowski@xxxxxxxxxxx> wrote: > >> > Enable reserved memory initialization from device tree. > >> > > >> > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > >> > >> This patch has hit -next and several legacy (non-DT) boot failures > >> were detected and bisected down to this patch. A quick scan looks > >> like there needs to be some sanity checking whether a DT is even > >> present. > > > > Hmm. Yes, the code unconditionally calls of_flat_dt_scan(), which will > > gladly touch initial_boot_params, even though it may be uninitialized. > > The below patch should allow these boards to boot... > > > > However, I'm wondering if there is a good reason why we don't parse the > > /reserved-memory nodes at the right after we parse the /memory nodes as > > part of early_init_dt_scan()... > > > > Thanks, > > Josh > > > > --8<-- > > Subject: [PATCH] drivers: of: only scan for reserved mem when fdt present > > > > Reported-by: Kevin Hilman <khilman@xxxxxxxxxx> > > Signed-off-by: Josh Cartwright <joshc@xxxxxxxxxxxxxx> > > This gets legacy boot working again. Thanks. > > Tested-by: Kevin Hilman <khilman@xxxxxxxxxx> Applied and confirmed on non-DT qemu boot. Thanks. It will be pushed out shortly. g. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
