Quoting Matthias Kaehlcke (2018-12-04 14:42:31) > Get the ref clock of the PHY from the device tree instead of > hardcoding its name and rate. > > Note: This change could break old out-of-tree DTS files that > use the 10nm PHY > > Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > --- > Changes in v4: > - none > > Changes in v3: > - fixed check for EPROBE_DEFER > - added note to commit message about breaking old DTS files > - added 'Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>' tag > > Changes in v2: > - remove anonymous array in clk_init_data assignment > - log error code if devm_clk_get() fails > - don't log devm_clk_get() failures for -EPROBE_DEFER > - updated commit message > --- > drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c > index 4c03f0b7343ed..2d23372acd20d 100644 > --- a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c > +++ b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c > @@ -91,6 +91,7 @@ struct dsi_pll_10nm { > void __iomem *phy_cmn_mmio; > void __iomem *mmio; > > + struct clk *vco_ref_clk; Same comment, and also get the name in probe or pass the clk pointer around instead of storing it forever. > u64 vco_ref_clk_rate; > u64 vco_current_rate; >