On Sun, Dec 9, 2018 at 4:14 PM Heiko Stuebner <heiko@xxxxxxxxx> wrote: > > Convert Rockchip SoC bindings to DT schema format using json-schema. > > Cc: Mark Rutland <mark.rutland@xxxxxxx> > Cc: Heiko Stuebner <heiko@xxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Cc: linux-rockchip@xxxxxxxxxxxxxxxxxxx > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > [move to per-board entries and added recently added boards] > Signed-off-by: Heiko Stuebner <heiko@xxxxxxxxx> > --- > Hi Rob, > > there are boards where the description adds much value and on others > it is maybe less, but personally I'd like to keep things uniform, > as that makes reading these things easier if the format stays the > same all the time, so I've gone forward and just did the conversion > > make dtbs_check did not complain about the schema it seems but I > did end up with an error later on: > > FATAL ERROR: Unknown output format "yaml" > make[2]: *** [scripts/Makefile.lib:313: arch/arm/boot/dts/rk3036-evb.dt.yaml] Fehler 1 You need libyaml and its headers installed so dtc can output yaml, but that's not needed for checking the schema against the meta-schema. > But I guess I did not mess up the schema yet. > > So does it look ok that way? Yes, but one comment... > + - description: Firefly Firefly-RK3288 > + items: > + - const: firefly,firefly-rk3288 > + - const: rockchip,rk3288 > + > + - description: Firefly Firefly-RK3288 (beta board) > + items: > + - const: firefly,firefly-rk3288-beta > + - const: rockchip,rk3288 > + > + - description: Firefly Firefly-RK3288 Reload Seems like combining these 3 (or first 2?) would make sense if this is just revs of the same board. But either way is fine. > + items: > + - const: firefly,firefly-rk3288-reload > + - const: rockchip,rk3288
