Re: [PATCH v6 8/8] mfd: axp20x: Add supported cells for AXP803

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lee,

On 12/7/18 6:40 PM, Lee Jones wrote:
On Tue, 20 Nov 2018, Oskari Lemmela wrote:

Parts of the AXP803 are compatible with their counterparts on the AXP813.
These include the GPIO, ADC, AC and battery power supplies.

Signed-off-by: Oskari Lemmela <oskari@xxxxxxxxxxx>
Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx>
Tested-by: Vasily Khoruzhick <anarsoul@xxxxxxxxx>
---
  drivers/mfd/axp20x.c | 15 +++++++++++++++
  1 file changed, 15 insertions(+)

diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
index dfc3cff1d08b..e415b967d38c 100644
--- a/drivers/mfd/axp20x.c
+++ b/drivers/mfd/axp20x.c
@@ -728,11 +728,26 @@ static const struct mfd_cell axp288_cells[] = {
static const struct mfd_cell axp803_cells[] = {
  	{
+		.name		= "axp20x-gpio",
+		.of_compatible	= "x-powers,axp813-gpio",
+	}, {
  		.name			= "axp221-pek",
  		.num_resources		= ARRAY_SIZE(axp803_pek_resources),
  		.resources		= axp803_pek_resources,
  	},
  	{	.name			= "axp20x-regulator" },
+	{
+		.name		= "axp813-adc",
+		.of_compatible	= "x-powers,axp813-adc",
+	}, {
+		.name		= "axp20x-battery-power-supply",
+		.of_compatible	= "x-powers,axp813-battery-power-supply",
+	}, {
+		.name		= "axp20x-ac-power-supply",
+		.of_compatible	= "x-powers,axp813-ac-power-supply",
+		.num_resources	= ARRAY_SIZE(axp20x_ac_power_supply_resources),
+		.resources	= axp20x_ac_power_supply_resources,
+	},
  };
My OCD-dar is going crazy.

Why haven't you used the same alignment as is already there?

If it starts to run over 80-chars then bring the others back.

Also why is there a single liner shoved in the middle of the
multi-line entries?  Please move the singles to the top or the
bottom.

I sent patch set v8 which contains ChenYu's re-align patch and
this patch rebased top of it.

Re-align patch will make number of whitespaces consistent in axp20x.c

Thanks,
Oskari





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux