Hi Hans and Dan,
On Fri 07 Dec 2018 at 13:38, Dan Carpenter wrote:
On Fri, Dec 07, 2018 at 01:44:00PM +0100, Hans Verkuil wrote:
CHECK: Alignment should match open parenthesis
#936: FILE: drivers/staging/media/imx/imx7-mipi-csis.c:921:
+ ret = v4l2_async_register_fwnode_subdev(mipi_sd,
+ sizeof(struct
v4l2_async_subdev), &sink_port, 1,
Apparently the latest coding style is that alignment is more
important than
line length, although I personally do not agree. But since you
need to
respin in any case due to the wrong SPDX identifier you used
you might as
well take this into account.
I added this in the cover letter:
- some alignment parenthesis that were left as they are, to
be more readable
this ones were left as they are as they seem impossible to fit all
rules. I hope you really do not mind about this checks. if you
have a strong opinion about this let me know, otherwise I will
leave this as it is.
I'm pretty sure it complains about both equally. If you make
fix one
warning it will complain about the other. So you just have to
pick
which warning to not care about.
Yeah, I agree with you, I normally like to avoid at all cost the
line length issue.
---
Cheers,
Rui
regards,
dan carpenter
