Hi Anson, On Thu, Dec 6, 2018 at 4:25 AM Anson Huang <anson.huang@xxxxxxx> wrote: > @@ -1533,6 +1535,14 @@ static int mma8452_probe(struct i2c_client *client, > data->client = client; > mutex_init(&data->lock); > data->chip_info = match->data; > + data->vcc_reg = devm_regulator_get_optional(&client->dev, "vcc"); MMA8452 datasheet shows two power supplies: VDD and VDDIO, so if you are adding support for the regulators, IMHO it is better to represent both supplies and with the same name they appear in the datasheet.
