Hi Lars, thanks for your patch! On Mon, Nov 26, 2018 at 1:22 PM Lars Povlsen <lars.povlsen@xxxxxxxxxxxxx> wrote: > +MSCC Serial GPIO driver Expand the acronym please, if IIUC this is "Microsemi Corporation (MSCC) Serial GPIO driver" > +- mscc,sgpio-frequency: The frequency at which the serial bitstream is > + generated and sampled. Default: 12500000 (Hz). Uhm what is a serial bitstream in this context, I am lost. Please elaborate. > +- mscc,sgpio-bitcount: The number of bits enabled per > + port. (1-4). Default: 2. Can't you just use the standard "ngpios" property for this? See Documentation/devicetree/bindings/gpio/gpio.txt Why is this a global setting for all ports and not per-port? > +- mscc,sgpio-ports: A bitmask (32 bits) of which ports are enabled in > + the serialized gpio stream. Default: 0xFFFFFFFF. I don't understand this either. Are there up to 32 ports? (Also referred to as "banks") with 1-4 GPIOs each? Yours, Linus Walleij
