On Wed, Nov 14, 2018 at 11:52 PM AKASHI Takahiro <takahiro.akashi@xxxxxxxxxx> wrote: > > Added function, fdt_setprop_reg(), will be used later to handle > kexec-specific property in arm64's kexec_file implementation. > It will possibly be merged into libfdt in the future. You generally can't modify libfdt files. Any changes will be blown away with the next dtc sync (there's one in -next now). Though here you are creating a new location with fdt code. lib/ is just a shim to the actual libfdt code. Don't put any implementation there. You can add this to drivers/of/fdt_address.c for the short term, but it still needs to go upstream. Otherwise, the implementation looks fine to me. > Signed-off-by: AKASHI Takahiro <takahiro.akashi@xxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Frank Rowand <frowand.list@xxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > --- > include/linux/libfdt.h | 26 ++++++++++++++++++++ > lib/Makefile | 2 +- > lib/fdt_addresses.c | 56 ++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 83 insertions(+), 1 deletion(-) > create mode 100644 lib/fdt_addresses.c
