On Tue, Dec 04, 2018 at 12:07:39PM +0100, Hans Ole Hatzel wrote:
> Add support for WiLink8 module which is connected via USDHC 2.
>
> Signed-off-by: Hans Ole Hatzel <hohatzel@xxxxxxxx>
> Signed-off-by: Julian Scheel <jscheel@xxxxxxxx>
> ---
> arch/arm/boot/dts/imx7d-cl-som-imx7.dts | 64 +++++++++++++++++++++++++
> 1 file changed, 64 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx7d-cl-som-imx7.dts b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
> index 11bd713b540f..e77e0cc7de39 100644
> --- a/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
> +++ b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
> @@ -30,6 +30,28 @@
> gpio = <&gpio1 5 GPIO_ACTIVE_HIGH>;
> enable-active-high;
> };
> +
> + rf_pwr_en_reg: regulator-rf-pwr-en {
> + compatible = "regulator-fixed";
> + regulator-name = "rf-pwr-en-regulator";
I think "rf-pwr-en" is good enough.
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpio = <&pca9555 9 GPIO_ACTIVE_HIGH>;
> + startup-delay-us = <70000>;
> + enable-active-high;
> + regulator-always-on;
> + };
> +
> + wlan_en_reg: regulator-wlan-en {
> + compatible = "regulator-fixed";
> + regulator-name = "wlan-en-regulator";
"wlan-en"
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpio = <&pca9555 0 GPIO_ACTIVE_HIGH>;
> + /* WLAN card specific delay */
> + startup-delay-us = <70000>;
> + enable-active-high;
> + };
> };
>
> &cpu0 {
> @@ -199,6 +221,28 @@
> status = "okay";
> };
>
> +&usdhc2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usdhc2>;
> + cd-gpios = <>;
> + wp-gpios = <>;
What do these mean?
> + no-1-8-v;
> + keep-power-in-suspend;
> + enable-sdio-wakeup;
The property is deprecated. Use "wakeup-source" instead.
> + vmmc-supply = <&wlan_en_reg>;
> + non-removable;
> + cap-power-off-card;
> + status = "okay";
Put 'status' at bottom of property list.
> + #address-cells = <1>;
> + #size-cells = <0>;
Have a newline between properties and child node.
> + wlcore: wlcore@0 {
> + compatible = "ti,wl1835";
> + reg = <2>;
The 'reg' property should match unit-address in node name.
Shawn
> + interrupt-parent = <&gpio1>;
> + interrupts = <15 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +};
> +
> &usdhc3 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_usdhc3>;
> @@ -211,6 +255,15 @@
> };
>
> &iomuxc {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_hog>;
> +
> + pinctrl_hog: hoggrp {
> + fsl,pins = <
> + MX7D_PAD_GPIO1_IO15__GPIO1_IO15 0x34 /* WLAN IRQ */
> + >;
> + };
> +
> pinctrl_enet1: enet1grp {
> fsl,pins = <
> MX7D_PAD_SD2_CD_B__ENET1_MDIO 0x30
> @@ -261,6 +314,17 @@
> >;
> };
>
> + pinctrl_usdhc2: usdhc2grp {
> + fsl,pins = <
> + MX7D_PAD_SD2_CMD__SD2_CMD 0x59
> + MX7D_PAD_SD2_CLK__SD2_CLK 0x19
> + MX7D_PAD_SD2_DATA0__SD2_DATA0 0x59
> + MX7D_PAD_SD2_DATA1__SD2_DATA1 0x59
> + MX7D_PAD_SD2_DATA2__SD2_DATA2 0x59
> + MX7D_PAD_SD2_DATA3__SD2_DATA3 0x59
> + >;
> + };
> +
> pinctrl_usdhc3: usdhc3grp {
> fsl,pins = <
> MX7D_PAD_SD3_CMD__SD3_CMD 0x59
> --
> 2.19.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
