On Mon, Dec 03, 2018 at 05:54:55PM -0600, Rob Herring wrote: > On Mon, Nov 12, 2018 at 12:31:02PM +0000, Russell King wrote: > > Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx> > > Needs a better subject and a commit msg. Hmm, not sure why it didn't contain: "dt-bindings: net: mvneta: add phys property Add an optional phys property to the mvneta binding documentation for the common phy. Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>" as the commit message. With the correct commit message, are you happy with it? > > > --- > > Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt b/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt > > index bedcfd5a52cd..691f886cfc4a 100644 > > --- a/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt > > +++ b/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt > > @@ -19,7 +19,7 @@ > > "marvell,armada-370-neta" and 9800B for others. > > - clock-names: List of names corresponding to clocks property; shall be > > "core" for core clock and "bus" for the optional bus clock. > > - > > +- phys: comphy for the ethernet port, see ../phy/phy-bindings.txt > > > > Optional properties (valid only for Armada XP/38x): > > > > -- > > 2.7.4 > > -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up