Hi Sugaya-san On Mon, Nov 19, 2018 at 10:01 AM Sugaya Taichi <sugaya.taichi@xxxxxxxxxxxxx> wrote: > > Add Milbeaut M10V pinctrl. > The M10V has the pins that can be used GPIOs or take multiple other > functions. > > Signed-off-by: Sugaya Taichi <sugaya.taichi@xxxxxxxxxxxxx> This patch was sent to: linux-clk@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx Unfortunately, the most important ML linux-gpio@xxxxxxxxxxxxxxx was not addressed. The pinctrl maintainer may not notice this patch. > diff --git a/drivers/pinctrl/pinctrl-m10v.c b/drivers/pinctrl/pinctrl-m10v.c > new file mode 100644 > index 0000000..d4ca713 > --- /dev/null > +++ b/drivers/pinctrl/pinctrl-m10v.c > @@ -0,0 +1,765 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2018 Socionext Ltd. > + * Copyright (C) 2015 Linaro Ltd. > + * Author: Jassi Brar <jaswinder.singh@xxxxxxxxxx> My company name is "Socionext Inc." instead of "Socionext Ltd." > +static struct platform_driver m10v_pinctrl_driver = { > + .probe = m10v_pinctrl_probe, > + .driver = { > + .name = "m10v-pinctrl", > + .of_match_table = m10v_pmatch, > + }, > +}; > + > +static int __init m10v_pinctrl_init(void) > +{ > + return platform_driver_register(&m10v_pinctrl_driver); > +} > +arch_initcall(m10v_pinctrl_init); Can't it be builtin_platform_driver()? Which device requires this to be arch_initcall()? -- Best Regards Masahiro Yamada