Re: [PATCH] ARM: dts: realview: Fix some more duplicate regulator nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 3, 2018 at 12:39 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> On Mon, Dec 3, 2018 at 8:12 PM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> > There's a bug in dtc in checking for duplicate node names when there's
> > another section (e.g. "/ { };"). In this case, skeleton.dtsi provides
> > another section. Upon removal of skeleton.dtsi, the dtb fails to build
> > due to a duplicate node 'fixedregulator@0'. As both nodes were pretty
> > much the same 3.3V fixed regulator, it hasn't really mattered. Fix this
> > by renaming the nodes to something unique. In the process, drop the
> > unit-address which shouldn't be present wtihout reg property.
> >
> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
>
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> Arm SoC folks: are you applying it directly like with the last
> one?

Yep, just did (but email didn't go out yet, I tend to batch them up).
Revisited and added your Reviewed-by though.


Thanks,

-Olof



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux