On Sat, 1 Dec 2018 at 10:27, Olof Johansson <olof@xxxxxxxxx> wrote: > > On Thu, Nov 29, 2018 at 07:52:51PM -0600, Rob Herring wrote: > > The base aspeed-g5.dtsi already defines a '/memory@80000000' node, so > > '/memory' in the board files create a duplicate node. We're probably > > getting lucky that the bootloader fixes up the memory node that the > > kernel ends up using. Add the unit-address so it's merged with the base > > node. > > > > Found with DT json-schema checks. > > > > Cc: Joel Stanley <joel@xxxxxxxxx> > > Cc: Andrew Jeffery <andrew@xxxxxxxx> > > Cc: devicetree@xxxxxxxxxxxxxxx > > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > > Cc: linux-aspeed@xxxxxxxxxxxxxxxx > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > > --- > > Might be better to just remove the node altogether from the SoC dtsi > > file. It's only saving the device_type definition. > > Since I'm sweeping DT pull requests right now, and this is pretty > straightforward, I've applied it to next/dt directly. Thanks Rob and Olof. Cheers, Joel