Hi Kevin, On Fri, Nov 30, 2018 at 9:15 PM Kevin Hilman <khilman@xxxxxxxxxxxx> wrote: > > Kevin Hilman <khilman@xxxxxxxxxxxx> writes: > > > Neil Armstrong <narmstrong@xxxxxxxxxxxx> writes: > > > >> On 28/10/2018 13:08, Martin Blumenstingl wrote: > >>> The clock controller on Meson8/Meson8m2 and Meson8b is part of a > >>> register region called "HHI". This register area contains more > >>> functionality than just a clock controller: > >>> - the clock controller > >>> - some reset controller bits > >>> - temperature sensor calibration data (on Meson8b and Meson8m2 only) > >>> - HDMI controller > >>> > >>> Allow access to this HHI register area as "system controller". Also > >>> migrate the Meson8 and Meson8b clock controllers to this new node. > >>> > >>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> > >>> Acked-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx> > >>> --- > >>> arch/arm/boot/dts/meson.dtsi | 7 +++++++ > >>> arch/arm/boot/dts/meson8.dtsi | 15 ++++++++------- > >>> arch/arm/boot/dts/meson8b.dtsi | 15 ++++++++------- > >>> 3 files changed, 23 insertions(+), 14 deletions(-) > >>> > >>> diff --git a/arch/arm/boot/dts/meson.dtsi b/arch/arm/boot/dts/meson.dtsi > >>> index 0d9faf1a51ea..ad903d1a2cb6 100644 > >>> --- a/arch/arm/boot/dts/meson.dtsi > >>> +++ b/arch/arm/boot/dts/meson.dtsi > >> > >> [...] > >> > >>> > >>> +&hhi { > >>> + clkc: clock-controller { > >>> + compatible = "amlogic,meson8-clkc"; > >>> + #clock-cells = <1>; > >>> + #reset-cells = <1>; > >>> + }; > >>> +}; > >>> + > >>> &hwrng { > >>> compatible = "amlogic,meson8b-rng", "amlogic,meson-rng"; > >>> clocks = <&clkc CLKID_RNG0>; > >>> > >> > >> Kevin, > >> > >> I didn't apply this one, but it can wait another cycle I think. > > > > OK, I'll take that one through my dt branch. > > > > I don't see any obvious dependency on the clock patches, > > ... and a quick boot test shows I was wrong, and should've (re)read > Martin's cover letter a couple more times. :) yes, there's a hard dependency on the clock patches > I think it's best to leave this one until the next cycle when all the > deps are merged. I have this on my "resend this for the next development cycle" list Regards Martin